Hoist vector transfers outside reduction and k loop #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 10, 2024 22:57
…de the reduction/k loop
rengolin
reviewed
Nov 11, 2024
adam-smnk
reviewed
Nov 12, 2024
|
|
||
| // Code to hoist vector transfer read before the reduction and k loop | ||
| if (auto vectorReadOp = contractOp.getOperand(contractOp.getNumOperands()-1).getDefiningOp()) { | ||
| auto subviewOp = vectorReadOp->getOperand(0).getDefiningOp(); |
There was a problem hiding this comment.
It needs some invariance check.
There was a problem hiding this comment.
I hope the updated code does the check. But, still want to confirm from you.
adam-smnk
reviewed
Nov 13, 2024
|
Add three negative test-cases. Two in unit tests and one in integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoists the vector transfer read and write operations of resultant matrix outside the reduction and k loop for a brgemm operation. This pass should be applied after the BrgemmLinalgTiling pass.